From bac9a576ee20970215dfe286ce69344c1bb28a07 Mon Sep 17 00:00:00 2001 From: Ewen Date: Thu, 9 May 2024 07:42:43 +0200 Subject: [PATCH] fix: changed order of required parameters --- api/api/feed.py | 7 ++++--- api/tests/test_parameters.py | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/api/api/feed.py b/api/api/feed.py index 8c9b56c..82c150f 100644 --- a/api/api/feed.py +++ b/api/api/feed.py @@ -40,12 +40,13 @@ def parse_page(): if not args.get("url"): raise InvalidParameters("Missing parameter: URL") - if not args.get("title"): - raise InvalidParameters("Missing parameter: title") - if not args.get("article"): raise InvalidParameters("Missing parameter: article") + if not args.get("title"): + raise InvalidParameters("Missing parameter: title") + + # Checking for correctness if not args.get("url").startswith("https"): args["url"] = "https://" + args.get("url") diff --git a/api/tests/test_parameters.py b/api/tests/test_parameters.py index 885a846..088e1b3 100644 --- a/api/tests/test_parameters.py +++ b/api/tests/test_parameters.py @@ -5,8 +5,8 @@ import pytest "url,missing_parameter", [ ("/feed/", "URL"), - ("/feed/?url=https://mozilla.org", "title"), - ("/feed/?url=https://mozilla.org&title=h2", "article"), + ("/feed/?url=https://mozilla.org", "article"), + ("/feed/?url=https://mozilla.org&article=article", "title"), ("/feed/?url=https://mozilla.org&title=h2&article=article", None), ], )